Fix Python process-pool test server lifecycle - #3677
Merged
Conversation
Client: py Co-Authored-By: OpenAI Codex (GPT-5.6) <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python process-pool tests currently stop the server through a four-second alarm and
os._exit(0). The abrupt exit bypasses normal multiprocessing cleanup, can report leaked semaphore objects, and forces every process-pool test to wait for the alarm.Observed macOS failures from this lifecycle include:
TProcessPoolServerwhile the client was still running and emitted leaked-semaphore warnings.This change replaces the alarm with a
SIGTERMhandler that unwindsTProcessPoolServer.serve()through its existingSystemExithandling. The client/server harness waits for the complete POSIX process group to exit and falls back toSIGKILLonly when graceful shutdown times out. Windows retains equivalent terminate-and-kill fallback behavior for its supported server types.This is a focused test-harness lifecycle fix, so Jira was intentionally skipped.
[skip ci]anywhere in the commit message to free up build resources.