Open
Conversation
- base file template for the new message validator - makes use of django app creator startapp
- within apps.py - update config to have the correct name
- Linked into the Apel RecordFactory - Doesn't make use of django model
- also cleans up some unnecessary code (unused exception handling) - validation output is also kept on submission and refresh
- has to import the apel record type classes - has an option for all, which uses the record header instead
- adds more comments - reworks exception handling - adds apel packages to requirements - adds styling - adds link to validator page onto home monitoring page
- move function definition out of other function - sort out stylesheet location error - fix APEL typo
- had 2 blank lines instead of 1
- has radio buttons to specifiy whether record should be validated or loaded
- adds new load method - creates instance of apel loader - makes use of a blackhole mariadb database, which doesn't store data
- also fixes validator bug which would prevent v0.4 records from getting a formatted output
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,3 @@ | |||
| from django.contrib import admin | |||
Check notice
Code scanning / CodeQL
Unused import Note
| @@ -0,0 +1,3 @@ | |||
| from django.test import TestCase | |||
Check notice
Code scanning / CodeQL
Unused import Note test
| } | ||
|
|
||
| except (configparser.NoSectionError) as err: | ||
| print("Error in configuration file. Check that file exists first: %s" % err) |
Check notice
Code scanning / CodeQL
Use of a print statement at module level Note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this currently contains all commits from #75 as well, but I believe it should sort itself out when that PR gets merged into dev?
host where this is running: http://host-172-16-103-131.nubes.stfc.ac.uk/validator/
Resolves GT-1228
Resolves GT-1328