fix(modem): validate stream type in demuxStream and flush on end#195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
demuxStreamblindly trusts the first byte of each 8-byte header as a valid Docker multiplex stream type. When the stream is not actually multiplexed (e.g. TTY mode) or framing becomes misaligned, a garbage type byte causes a garbage frame length, which misaligns every subsequent frame. The result is corrupted leading bytes in the demuxed output.This forces downstream consumers to add workarounds like:
See for example:
Related (may fix) issues:
Changes: