fix(web): forward provider view props and listen for standard transitions - #765
Open
OskarEichler wants to merge 2 commits into
Open
fix(web): forward provider view props and listen for standard transitions#765OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transitionproperty and use the correcttransitionendevent, before legacy prefixes. The existingTransition/transitionEndpair never identifies standard CSS transitions, leaving env() inset changes unreported in standard-only environments.No API or native implementation changes. Previously dropped View props now reach the backing View; standard inset transitions now trigger the existing measurement callback. Existing cleanup and prefixed fallbacks are retained.
Test Plan
React Native 0.87.1 consumer: immutable install and lint, all 13 web production targets, all four browser-extension builds, and all four production-mode Metro bundles pass. 172 installed source/native/artifact files match the verified fork. Native implementation is unchanged; both products' Android/iOS Debug builds passed immediately before this JS-only batch.
Existing Jest suite: 21 tests / four suites / 11 snapshots pass.
TypeScript, ESLint (three existing deep-import warnings), targeted Prettier, CJS/ESM/declaration builds and whitespace checks pass.
Actual source components with React 19/JSDOM: both providers forward testID/onLayout; a standard transition event updates insets exactly once; unmount removes the measurement element and resize listener. Baseline drops both providers' props and produces zero updates for that event.
React Doctor: 86/100, only the existing compatibility-provider measurement-through-effect warning. No rule suppression.
No test/spec files changed. Event/measurement checks use DOM mocks, not a real mobile browser/device notch.