K8s plugin - #2044
Merged
Merged
Conversation
Contributor
|
@jshi991 Please resubmit with verified commit signatures. Thanks! |
jshi991
force-pushed
the
k8s-plugin-upstream
branch
3 times, most recently
from
July 30, 2026 21:49
ad88d2c to
b22f47d
Compare
Contributor
|
@jshi991 In the PR description, please remove the alert regarding signed commits, and replace it with a short bullet list: |
jshi991
force-pushed
the
k8s-plugin-upstream
branch
2 times, most recently
from
July 30, 2026 23:58
ea989c5 to
66d1e39
Compare
perplexiphone-cmd
approved these changes
Jul 31, 2026
jshi991
force-pushed
the
k8s-plugin-upstream
branch
from
July 31, 2026 23:10
66d1e39 to
d6775ed
Compare
jglogan
requested changes
Aug 3, 2026
jglogan
requested changes
Aug 4, 2026
jglogan
left a comment
Contributor
There was a problem hiding this comment.
Two more change requests:
- Rebase your PR onto latest main to pick up the fix from @JaewonHur to move the ssh build test to the serial tests.
- Increase the timeout in the
.github/workflows/common.yamlfile from 70 to 90 minutes, as we don't know how much additional time your tests will need.
jshi991
force-pushed
the
k8s-plugin-upstream
branch
4 times, most recently
from
August 4, 2026 22:10
d8c46e8 to
d2eb649
Compare
jglogan
requested changes
Aug 5, 2026
jshi991
force-pushed
the
k8s-plugin-upstream
branch
3 times, most recently
from
August 5, 2026 05:18
dbc6a1e to
0b5a6e9
Compare
jglogan
requested changes
Aug 5, 2026
jshi991
force-pushed
the
k8s-plugin-upstream
branch
from
August 5, 2026 17:26
6489122 to
97ced0c
Compare
jshi991
force-pushed
the
k8s-plugin-upstream
branch
from
August 5, 2026 18:34
561427c to
e394cfe
Compare
jshi991
force-pushed
the
k8s-plugin-upstream
branch
from
August 5, 2026 21:25
e394cfe to
4aa5548
Compare
Code Coverage
|
jglogan
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.