Skip to content

K8s plugin - #2044

Merged
jglogan merged 4 commits into
apple:mainfrom
jshi991:k8s-plugin-upstream
Aug 6, 2026
Merged

K8s plugin#2044
jglogan merged 4 commits into
apple:mainfrom
jshi991:k8s-plugin-upstream

Conversation

@jshi991

@jshi991 jshi991 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
  • closes [Request]: k8s plugin #2043
  • introduces the k8s plugin, allowing users to make single node clusters with the kind base image
  • other functionality is included as well such as creation, deletion, and loading custom images

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 30, 2026
@jglogan

jglogan commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@jshi991 Please resubmit with verified commit signatures. Thanks!

@jshi991
jshi991 force-pushed the k8s-plugin-upstream branch 3 times, most recently from ad88d2c to b22f47d Compare July 30, 2026 21:49
@jshi991 jshi991 changed the title K8s plugin upstream K8s plugin Jul 30, 2026
@jglogan

jglogan commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@jshi991 In the PR description, please remove the alert regarding signed commits, and replace it with a short bullet list:

- Closes #2043.
- Any brief description bullet items you want to make about the change.
...

@jshi991
jshi991 force-pushed the k8s-plugin-upstream branch 2 times, most recently from ea989c5 to 66d1e39 Compare July 30, 2026 23:58
@jshi991
jshi991 force-pushed the k8s-plugin-upstream branch from 66d1e39 to d6775ed Compare July 31, 2026 23:10
Comment thread Sources/Plugins/K8s/K8sHelper.swift Outdated
Comment thread Sources/Plugins/K8s/K8sHelper.swift Outdated
Comment thread Sources/Plugins/K8s/KubeConfig.swift
Comment thread Sources/Plugins/K8s/Resources/KubeConfig.swift Outdated
Comment thread Sources/Plugins/K8s/Resources/KubeConfig.swift Outdated
Comment thread docs/command-reference.md
Comment thread Sources/Plugins/K8s/K8sCommand.swift Outdated

@jglogan jglogan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more change requests:

  • Rebase your PR onto latest main to pick up the fix from @JaewonHur to move the ssh build test to the serial tests.
  • Increase the timeout in the .github/workflows/common.yaml file from 70 to 90 minutes, as we don't know how much additional time your tests will need.

@jshi991
jshi991 force-pushed the k8s-plugin-upstream branch 4 times, most recently from d8c46e8 to d2eb649 Compare August 4, 2026 22:10

@jglogan jglogan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jshi991 You may be missing a feature needed for running up on GH. Anything that goes to the network needs to have proxy variables set.

@jshi991
jshi991 force-pushed the k8s-plugin-upstream branch 3 times, most recently from dbc6a1e to 0b5a6e9 Compare August 5, 2026 05:18
Comment thread Sources/Plugins/K8s/K8sCreate.swift Outdated
@jshi991
jshi991 force-pushed the k8s-plugin-upstream branch from 6489122 to 97ced0c Compare August 5, 2026 17:26
@jshi991
jshi991 force-pushed the k8s-plugin-upstream branch from 561427c to e394cfe Compare August 5, 2026 18:34
@jshi991
jshi991 force-pushed the k8s-plugin-upstream branch from e394cfe to 4aa5548 Compare August 5, 2026 21:25
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Code Coverage

Tier Line Coverage
Unit 24.28%
Integration 66.84%
Combined 76.19%

@jglogan
jglogan merged commit 0d111be into apple:main Aug 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: k8s plugin

3 participants