Backport to 7.4: add retry limit to startMoveKeys to prevent infinite loops (#13176) - #13782
Open
saintstack wants to merge 1 commit into
Open
Backport to 7.4: add retry limit to startMoveKeys to prevent infinite loops (#13176)#13782saintstack wants to merge 1 commit into
saintstack wants to merge 1 commit into
Conversation
…(PR 13176) Add START_MOVE_KEYS_MAX_RETRIES knob (default 50, BUGGIFY=10) and throw start_move_keys_too_many_retries when exceeded. Wire the new error into DDRelocationQueue (same light-weight re-queue handler as finish_move_keys_too_many_retries and move_to_removed_server) and normalDDQueueErrors so DD does not restart. Also propagate actor_cancelled before the retry limit check in startMoveKeys.
Contributor
Result of foundationdb-pr-clang on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Contributor
Result of foundationdb-pr on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Contributor
Result of foundationdb-pr-macos on macOS 14.x
|
gxglass
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add START_MOVE_KEYS_MAX_RETRIES knob (default 50, BUGGIFY=10) and throw start_move_keys_too_many_retries when exceeded. Wire the new error into DDRelocationQueue (same light-weight re-queue handler as finish_move_keys_too_many_retries and move_to_removed_server) and normalDDQueueErrors so DD does not restart. Also propagate actor_cancelled before the retry limit check in startMoveKeys.
20260724-003619-stack-backport-7.4-eac563f902694355 compressed=True data_size=41563174 duration=3238562 ended=100000 fail=5 fail_fast=10 max_runs=100000 pass=99995 priority=100 remaining=0 runtime=0:31:27 sanity=False started=100000 stopped=20260724-010746 submitted=20260724-003619 timeout=5400 username=stack-backport-7.4The 5 failures are all 'RandomSeed="1520625388" SourceVersion="ac41ec01f6c2b74a6c1432bb75f874a9c3ab2dd2" Time="1784853672" BuggifyEnabled="0" DeterminismCheck="0" FaultInjectionEnabled="1" TestFile="tests/fast/MinimumThroughput.toml"'. I'll fix in a different PR. The failures are not related to here.
(They are fixed over in #13783)