Skip to content

Extract mapped-range key codec into MappedKeyPlan - #13843

Merged
tclinkenbeard-oai merged 1 commit into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/mapped-key-codec
Aug 13, 2026
Merged

Extract mapped-range key codec into MappedKeyPlan#13843
tclinkenbeard-oai merged 1 commit into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/mapped-key-codec

Conversation

@tclinkenbeard-oai

@tclinkenbeard-oai tclinkenbeard-oai commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Extract mapped-range mapper parsing and key construction into a private MappedKeyPlan within the storage-server component.
  • Preserve escaped literals, key/value tuple substitutions, range markers, error handling, and mapped-key ownership.
  • Extend mapped-key coverage to verify that key and value tuples are decoded only when the mapper references them.

This helps to reduce the size of the large storageserver.cpp file.

Validation

  • fdbserver_storageserver_test
  • fdbserver_storageserver_test -f /fdbserver/storageserver/constructMappedKey

@tclinkenbeard-oai
tclinkenbeard-oai marked this pull request as ready for review August 11, 2026 18:22
@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS 14.x

  • Commit ID: c5e506a
  • Duration 0:34:43
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: c5e506a
  • Duration 0:40:23
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux RHEL 9

  • Commit ID: c5e506a
  • Duration 0:47:28
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS 14.x

  • Commit ID: c5e506a
  • Duration 0:49:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: c5e506a
  • Duration 1:07:58
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: c5e506a
  • Duration 1:17:56
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: c5e506a
  • Duration 1:35:57
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@tclinkenbeard-oai
tclinkenbeard-oai merged commit ea4b54f into apple:main Aug 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants