Skip to content

[release-7.4] Fix an old exclude failed bug #13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spraza wants to merge 3 commits into
base: release-7.4
Choose a base branch
from
+6 −4
Open

[release-7.4] Fix an old exclude failed bug #13869

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
817f31c
Fix an old exclude failed bug (#13645)
spraza Aug 13, 2026
17f7513
Merge branch 'release-7.4' into port-7.4-pr13645
saintstack Aug 14, 2026
f55cfdd
Merge branch 'release-7.4' into port-7.4-pr13645
ploxiln Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions fdbserver/MoveKeys.actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3070,7 +3070,7 @@ ACTOR Future<Void> removeKeysFromFailedServer(Database cx,
}
}

const UID shardId = newDataMoveId(deterministicRandom()->randomUInt64(),
state UID shardId = newDataMoveId(deterministicRandom()->randomUInt64(),
AssignEmptyRange::True,
DataMoveType::LOGICAL,
DataMovementReason::ASSIGN_EMPTY_RANGE);
Expand All @@ -3089,20 +3089,22 @@ ACTOR Future<Void> removeKeysFromFailedServer(Database cx,
actors.push_back(
krmSetRangeCoalescing(&tr, serverKeysPrefixFor(id), range, allKeys, serverKeysFalse));
}
wait(waitForAll(actors));

// Assign the shard to the new team as an empty range.
// Note, there could be data loss.
std::vector<Future<Void>> emptyRangeActors;
for (const UID& id : teamForDroppedRange) {
if (SERVER_KNOBS->SHARD_ENCODE_LOCATION_METADATA) {
actors.push_back(krmSetRangeCoalescing(
emptyRangeActors.push_back(krmSetRangeCoalescing(
&tr, serverKeysPrefixFor(id), range, allKeys, serverKeysValue(shardId)));
} else {
actors.push_back(krmSetRangeCoalescing(
emptyRangeActors.push_back(krmSetRangeCoalescing(
&tr, serverKeysPrefixFor(id), range, allKeys, serverKeysTrueEmptyRange));
}
}

wait(waitForAll(actors));
wait(waitForAll(emptyRangeActors));

TraceEvent trace(SevWarnAlways, "ShardLossAllReplicasDropShard", serverID);
trace.detail("Begin", it.key);
Expand Down