Skip to content

Fail pending requests before stopping the flow #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkuk24 merged 1 commit into from
Aug 14, 2026
+5 −6
Merged

Fail pending requests before stopping the flow #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions Sources/SwiftNetwork/EndpointFlow/EndpointFlow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,15 +319,14 @@ final class EndpointFlow: CustomDebugStringConvertible {
self.cancelRequested = true
Logger.connection.debug("EndpointFlow: \(self.debugDescription) cancel called (force=\(force))")

// 1. Stop the current flow.
// Graceful close of a flow defers teardown until
// Fail anything still queued; it can no longer complete
self.failPendingRequests()

// Stop the current flow. Graceful close of a flow defers teardown until
// the `disconnected` event arrives.
let teardownDeferred = self.stopFlow(force: force, error: error)

// 2. Fail anything still queued; it can no longer complete
self.failPendingRequests()

// 3. Detach and mark cancelled (now, or from the disconnected
// Detach and mark cancelled (now, or from the disconnected
// callback for the deferred graceful path).
if !teardownDeferred {
self.completeTeardown()
Expand Down
Loading