Reduce Deserializer CPU Usage by almost 3x - #82
Open
agnosticdev wants to merge 2 commits into
Open
Conversation
agnosticdev
requested review from
ekinnear,
kkuk24,
rpaulo and
tfpauly
as code owners
August 13, 2026 21:28
tfpauly
approved these changes
Aug 13, 2026
| if #available(anyAppleOS 26, *) { | ||
| // Take command line arguments | ||
| var iterations = 1 // 5gb total (if 500000 sendSize) | ||
| var iterations = 10000 // 5gb total (if 500000 sendSize) |
Collaborator
There was a problem hiding this comment.
Was this accidentally changed before?
Collaborator
Author
There was a problem hiding this comment.
It was... by me...
Collaborator
There was a problem hiding this comment.
Thanks for fixing =) Just confirming
Collaborator
|
Benchmark build failing with |
Collaborator
Author
Addressed in 6c958f8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the deserializer CPU usage by almost 3x. Added a benchmark for incremental investigation.
Top of tree:
With this change: