Allow an ENV var for APPPACK_TOML to specify the path to the toml file. See Issue #10#11
Allow an ENV var for APPPACK_TOML to specify the path to the toml file. See Issue #10#11
Conversation
3842cf3 to
a9d1261
Compare
|
This looks correct to me. What do you think about factoring this out into a small function? filename := "apppack.toml"
if envFile := os.Getenv("APPPACK_TOML"); envFile != "" {
filename = envFile
}That would be something that we (or your favorite LLM) could add a simple test for. If the tests pass, we can deploy to a canary environment. I can help with that next week. |
Great. What about docs or changelogs for the new behavior? |
a9d1261 to
5dd49d6
Compare
5dd49d6 to
7a75a5c
Compare
|
This MR updated and also: |
CHANGELOG.md
Outdated
|
|
||
| ## [2.2.0] - 2025-06-12 | ||
|
|
||
| ### Improved |
There was a problem hiding this comment.
There's a list of headers here at https://keepachangelog.com/en/1.1.0/#how
I would use Added
builder/build/prebuild.go
Outdated
| if appJsonExists && !apppackTomlExists { | ||
| // convert app.json to apppack.toml | ||
| b.Log().Info().Msg("Converting app.json to apppack.toml") | ||
| b.Log().Info().Msg(fmt.Sprintf("Converting %s to %s", "app.json", filename)) |
* Update changelog verb. * Unset env var after test. * Fix an unnecessary string formatt
|
These commits should be squashed before merging. |
Draft, not yet tested. Pushing to see what parts get built/run/tested automatically on branches