Skip to content

added missing site for recording chunks #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnabChatterjee20k wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added missing site for recording chunks #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 50 additions & 5 deletions crates/claudear-engine/src/processing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1834,6 +1834,7 @@ impl IssueProcessor {
&input.resolution,
&input.source_name,
context_provider,
input.attempt_id,
)
.await;
ProcessingOutcome::CompletedNoPr {
Expand All @@ -1855,6 +1856,7 @@ impl IssueProcessor {
&input.resolution,
&input.source_name,
context_provider,
input.attempt_id,
)
.await
}
Expand Down Expand Up @@ -1900,6 +1902,7 @@ impl IssueProcessor {
&input.resolution,
&input.source_name,
context_provider,
input.attempt_id,
)
.await;
if verdict.reproduced {
Expand All @@ -1926,6 +1929,7 @@ impl IssueProcessor {
&input.resolution,
&input.source_name,
context_provider,
input.attempt_id,
)
.await
} else {
Expand All @@ -1935,6 +1939,7 @@ impl IssueProcessor {
&input.resolution,
&input.source_name,
context_provider,
input.attempt_id,
)
.await
}
Expand Down Expand Up @@ -2011,9 +2016,10 @@ impl IssueProcessor {
resolution: &RepoResolution,
source_name: &str,
context_provider: &dyn ContextProvider,
attempt_id: Option<i64>,
) -> VerifyResult {
let project_dir = self.action_project_dir(resolution);
let context = self.build_rag_context(issue).await;
let context = self.build_rag_context(issue, attempt_id).await;

self.record_issue_decision(
issue,
Expand Down Expand Up @@ -2129,9 +2135,10 @@ impl IssueProcessor {
resolution: &RepoResolution,
source_name: &str,
context_provider: &dyn ContextProvider,
attempt_id: Option<i64>,
) -> ProcessingOutcome {
let project_dir = self.action_project_dir(resolution);
let context = self.build_rag_context(issue).await;
let context = self.build_rag_context(issue, attempt_id).await;

// The inbox key is the HelpScout mailbox id when present, else the source.
let inbox_key = issue
Expand Down Expand Up @@ -2236,7 +2243,9 @@ impl IssueProcessor {

/// Retrieve RAG grounding context for an issue from the code index, plus any
/// indexed Discord discussions.
async fn build_rag_context(&self, issue: &Issue) -> String {
/// Build the RAG grounding context for the action pipeline (verify/reply).
Comment thread
ArnabChatterjee20k marked this conversation as resolved.
async fn build_rag_context(&self, issue: &Issue, attempt_id: Option<i64>) -> String {
let mut retrieved_items: Vec<RetrievedItem> = Vec::new();
let mut context = String::new();
if let Some(ref code_search) = self.code_search_service {
let query = claudear_analysis::repo::code_index::build_code_search_query(issue);
Expand All @@ -2245,21 +2254,57 @@ impl IssueProcessor {
.await
{
if !results.is_empty() {
if let Some(id) = attempt_id {
let mut rows: Vec<RetrievalUsageRecord> = Vec::with_capacity(results.len());
for (rank, r) in results.iter().enumerate() {
let chunk_ref = r
.chunk
.id
.map(|i| i.to_string())
.unwrap_or_else(|| r.chunk.file_path.clone());
retrieved_items.push(RetrievedItem {
source_kind: "code_chunk".to_string(),
chunk_ref: chunk_ref.clone(),
text: r.chunk.chunk_text.clone(),
});
rows.push(RetrievalUsageRecord::new(
id,
"code_chunk",
chunk_ref,
Some(r.chunk.file_path.clone()),
rank as i64,
r.score,
Some(r.chunk.chunk_text.chars().count() as i64),
));
}
self.tracker.record_retrieval_usage(&rows).ok();
self.log_retrieval_recorded(&rows);
}
context =
claudear_analysis::repo::code_index::format_code_search_context(&results);
}
}
}
let (discord_ctx, _) = self
.discord_grounding_context(issue, self.config.qa.max_context_chunks, None)
let (discord_ctx, discord_items) = self
.discord_grounding_context(issue, self.config.qa.max_context_chunks, attempt_id)
.await;
if !discord_ctx.is_empty() {
context = if context.is_empty() {
discord_ctx
} else {
format!("{}\n{}", context, discord_ctx)
};
if attempt_id.is_some() {
retrieved_items.extend(discord_items);
}
}

// Score retrieval quality for this action run (opt-in, detached — never
// blocks the reply/verify). Mirrors the Q&A pipeline.
if let Some(id) = attempt_id {
self.spawn_retrieval_judge(id, issue, &retrieved_items);
}

context
}

Expand Down
Loading