feat: SDK update for version 26.1.0#68
Conversation
Greptile SummaryUpdates the Ruby SDK to version 26.1.0.
Confidence Score: 5/5The PR appears safe to merge based on this follow-up review. No new blocking failure eligible for this follow-up remains. Important Files Changed
Reviews (2): Last reviewed commit: "chore: update Ruby SDK to 26.1.0" | Re-trigger Greptile |
| # | ||
| # @return [BackupRestoration] | ||
| def create_restoration(archive_id:, services:, new_resource_id: nil, new_resource_name: nil, new_specification: nil) | ||
| def create_restoration(archive_id:, services:, new_resource_id: nil, new_resource_name: nil) |
There was a problem hiding this comment.
Restoration keyword compatibility broken
When code written against 26.0.0 passes the documented new_specification: keyword, this reduced signature raises ArgumentError: unknown keyword: :new_specification before sending the restoration request. Retain compatibility or release and document this as a breaking API change.
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/appwrite/services/backups.rb
Line: 351
Comment:
**Restoration keyword compatibility broken**
When code written against 26.0.0 passes the documented `new_specification:` keyword, this reduced signature raises `ArgumentError: unknown keyword: :new_specification` before sending the restoration request. Retain compatibility or release and document this as a breaking API change.
How can I resolve this? If you propose a fix, please make it concise.|
|
||
| def self.from(map:) | ||
| DatabaseStatusVolume.new( | ||
| xpath: map["path"], |
There was a problem hiding this comment.
The API's path field is assigned to the model's xpath attribute, forcing SDK consumers to use an unrelated public name for the volume path. Rename the initializer, reader, and backing variable to path so the Ruby model matches its serialized field.
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/appwrite/models/database_status_volume.rb
Line: 25
Comment:
**Volume path exposed as xpath**
The API's `path` field is assigned to the model's `xpath` attribute, forcing SDK consumers to use an unrelated public name for the volume path. Rename the initializer, reader, and backing variable to `path` so the Ruby model matches its serialized field.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This PR contains updates to the SDK for version 26.1.0.
What's Changed
Appsservice for managing OAuth2 applications, keys, and installationsOAuth2service with authorize, grant, device authorization, and consent flowslist_consents,get_consent,delete_consent, and consent token methodsOrganizationandTeamsservicesinstallation_access_token_durationparameter toproject.update_o_auth2_servertokenparameter tosites.get_deployment_downloadoauth2.introspectand organization installation key scopes