Method to retrieve Arbor configuration in C++ / cleanup of busyring example - #2519
Open
jlubo wants to merge 4 commits into
Open
Method to retrieve Arbor configuration in C++ / cleanup of busyring example #2519jlubo wants to merge 4 commits into
jlubo wants to merge 4 commits into
Conversation
Contributor
|
Hi @jlubo, thank you, having the configuration as a table of values at runtime is really helpful. However, I am not sure though whether locking this to a string is necessarily the most useful way of implementing the functionality. My feeling is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a method to get a string representation of the Arbor configuration in C++ (analogously to the
config()method that has already been available for the Python frontend).While the C++ function was already introduced by PR #2489 within the busyring example, this PR makes it globally available as a member of the
arbclass.The PR further introduces small fixes for the busyring example (in the most recent version, the synapse number was off by 1) and for the profiler (missing header file).