GenericConnectionHandler: uniform functions order and layout#149
Merged
pennam merged 1 commit intoarduino-libraries:masterfrom Feb 9, 2026
Merged
GenericConnectionHandler: uniform functions order and layout#149pennam merged 1 commit intoarduino-libraries:masterfrom
pennam merged 1 commit intoarduino-libraries:masterfrom
Conversation
|
Memory usage change @ 20283aa
Click for full report table
Click for full report CSV |
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the GenericConnectionHandler.cpp file to improve code structure and maintainability by standardizing the order and layout of functions.
Key changes:
- Moved the
instantiate_handlerstatic function from bottom to top and implemented it inline (previously was just a forward declaration at the top) - Added section headers to clearly demarcate LOCAL MODULE FUNCTIONS, PUBLIC MEMBER FUNCTIONS, and PROTECTED MEMBER FUNCTIONS
- Relocated protected member functions (
updateConnectionState,update_handle*methods) to the bottom of the file under a dedicated section
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andreagilardoni
approved these changes
Jan 20, 2026
20283aa to
8db79ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.