Open
Conversation
Open
0e5955a to
ecb4574
Compare
ecb4574 to
4a57839
Compare
Note that the match compiler needs revert built into Core (i.e. __revert__), since it may revert with a message. Using a high-level revert function would introduce a dependency between the compiler and the std library. Co-authored-by: Alex Oltean <aoltean@mailbox.org>
4a57839 to
933bb19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for string literals, implementing #264. Each string literal is desugared to the application of a new function, which stores chunks in memory and returns their starting pointer.
In the test cases, I used this to define high-level
revertandassertfunctions similar to regular Solidity.Please note that string literals in pattern matching equations are still not supported. For example, this code snippet will not compile (but it does not compile on the main branch either):