Open
Conversation
gangli01
reviewed
May 12, 2024
| if (cmb_get_sp() == cmb_get_psp()) { | ||
| get_cur_thread_stack_info(sp, &stack_start_addr, &stack_size); | ||
| } | ||
| } |
There was a problem hiding this comment.
Hi @caoliuchao, 我觉得{}位置没错，下面是我的看法：
if (on_thread_before_fault)是为了切换到psp stack, 如果按照你的修改，能走到else case，那就意味着发生hardfault之前是handler mode, 此时没有必要再去检查是否为psp stack。- 如果没有发生hardfault，
cm_backtrace_call_stack默认使用msp，但当前可能处于handler mode或者thread mode，如果是thread mode，需要切换到psp stack。这就是else case。（如果按照你的修改，即使处于thread mode，还是在用msp stack。)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.