fix: miscellaneous minor warnings in the test build#168
Merged
embray merged 1 commit intoasdf-format:mainfrom Mar 30, 2026
Merged
fix: miscellaneous minor warnings in the test build#168embray merged 1 commit intoasdf-format:mainfrom
embray merged 1 commit intoasdf-format:mainfrom
Conversation
embray
changed the title
embray
force-pushed
the
build-warnings
branch
2 times, most recently
from
ac0b488 to
c6b59d9
Compare
The -std=gnu11 change stems from the error system refactoring, where we do rely on variadic macros that may take zero arguments. This uses the ##__VA_ARGS__ gnu extension which was implict in the main library build but warned about in the tests due to the explicit -std=c11 flag. Since ##__VA_ARGS__ is supported in GCC and clang I'm relenting to use it for now; could move to C23 which has __VA_OPT__ but I'd like to stick mainly to an older C standard for now but not shy away from a few extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -std=gnu11 change stems from the error system refactoring, where we do rely on variadic macros that may take zero arguments. This uses the ##VA_ARGS gnu extension which was implict in the main library build but warned about in the tests due to the explicit -std=c11 flag.
Since ##VA_ARGS is supported in GCC and clang I'm relenting to use it for now; could move to C23 which has VA_OPT but I'd like to stick mainly to an older C standard for now but not shy away from a few extensions.