Add Deviation and StDev columns to Blazor first-ui regression template - #2194
Open
LoopedBard3 wants to merge 1 commit into
Open
Add Deviation and StDev columns to Blazor first-ui regression template#2194LoopedBard3 wants to merge 1 commit into
LoopedBard3 wants to merge 1 commit into
Conversation
The first-ui template (used for the blazorwasm/time-to-first-ui probe) omitted the Deviation and StDev columns that the rps and download-size templates already render, so those columns were missing from filed time-to-first-ui regression issues (e.g. dotnet/aspnetcore#68100). The data is already available on the Regression object (regression.StandardDeviation, and deviation = Change / StandardDeviation), so this is a template-only change that brings first-ui in line with the other regression report templates. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a46e499b-934c-4f39-b013-e3384a46eb97
There was a problem hiding this comment.
Pull request overview
Updates the Blazor first-ui regression issue template to display statistical context (Deviation and Standard Deviation) alongside existing regression metrics, aligning it with the other Blazor regression templates.
Changes:
- Adds
DeviationandStDevcolumns to thefirst-uimarkdown table header/separator. - Computes
deviation = regression.Change / regression.StandardDeviationand renders both deviation (σ) and standard deviation (formattedN2).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the Deviation and StDev columns to the
first-uiregression report template inbuild/regressions.blazor.config.yml(the template used for theblazorwasm/time-to-first-uiprobe).Why
Time-to-first-ui regression issues (e.g. dotnet/aspnetcore#68100) were missing the Deviation/StDev columns that the
rps(e.g. dotnet/aspnetcore#67745) anddownload-sizetemplates already render. The cause was purely cosmetic: thefirst-uitemplate header simply never defined those two columns — it mirrored thestart-timetemplate, which also omits them.The underlying data is already computed by crank''s RegressionBot and available on the
Regressionobject (regression.StandardDeviation, withdeviation = regression.Change / regression.StandardDeviation), exactly as the siblingdownload-sizetemplate already uses it. So this is a template-only change with no dependency on run data.StDevis formattedN2(rather than thedownload-sizetemplate''sN0) since time-to-first-ui values are small millisecond quantities where sub-integer standard deviations are meaningful.Notes