Handle ValueError in _format when float conversion fails for bool-like strings#394
Open
bysiber wants to merge 1 commit intoastanin:masterfrom
Open
Handle ValueError in _format when float conversion fails for bool-like strings#394bysiber wants to merge 1 commit intoastanin:masterfrom
bysiber wants to merge 1 commit intoastanin:masterfrom
Conversation
When a column contains both bool-like strings ('True'/'False') and
numeric strings, the column type is detected as float. Formatting then
crashes with ValueError on float('False').
Catch ValueError and TypeError in the float branch of _format and fall
back to string formatting.
Fixes astanin#209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #209.
When a column contains both bool-like strings (
'True'/'False') and numeric strings (e.g.'1.'), the column type is detected asfloat. Then_formatcallsfloat('False')which raisesValueError.The fix catches
ValueError/TypeErrorin the float formatting branch of_formatand falls back to string formatting for unconvertible values.Before:
After: