fix: handle empty tables when maxheadercolwidths is set#395
Open
Jo2234 wants to merge 1 commit intoastanin:masterfrom
Open
fix: handle empty tables when maxheadercolwidths is set#395Jo2234 wants to merge 1 commit intoastanin:masterfrom
Jo2234 wants to merge 1 commit intoastanin:masterfrom
Conversation
When tabulate() is called with an empty table and maxheadercolwidths
is not None, an IndexError is raised at:
num_cols = len(list_of_lists[0])
because list_of_lists is an empty list.
This fix:
- Falls back to len(headers) when list_of_lists is empty
- Skips header width wrapping entirely when num_cols is 0
(no columns to wrap)
Fixes astanin#365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
IndexErrorwhentabulate()is called with an empty table andmaxheadercolwidthsis notNone.Problem
The crash occurs at:
Fix
This mirrors the approach already used for
maxcolwidths(lines 2250-2253) which correctly handles empty tables.Fixes #365