Skip to content

refactor: use cargo verus instead of Verus - #28

Merged
rikosellic merged 8 commits into
asterinas:mainfrom
Marsman1996:cargo-verus
Jul 2, 2026
Merged

refactor: use cargo verus instead of Verus#28
rikosellic merged 8 commits into
asterinas:mainfrom
Marsman1996:cargo-verus

Conversation

@Marsman1996

Copy link
Copy Markdown
Collaborator

No description provided.

@Marsman1996
Marsman1996 requested a review from rikosellic July 2, 2026 08:17
Comment thread src/verus.rs Outdated
@rikosellic

Copy link
Copy Markdown
Collaborator

Maybe we can add a description in the README that this is a thin wrapper of cargo verus that extends some functionalities like fmt.

@rikosellic

Copy link
Copy Markdown
Collaborator

Please wait until I try this on Windows.

@rikosellic

Copy link
Copy Markdown
Collaborator

It works on my machine as before. The only observable difference in behaviour is that cargo dv verify --targets ostd will now not re-verify if nothing has changed, but this is actually a bug in the old dv. Glad to see that this is finally fixed.

@rikosellic

Copy link
Copy Markdown
Collaborator

Two suggestions:

  1. Can we align the behaviour of cargo dv verify with cargo verus verify when no targets are provided? verus verify will just verify all crates, our old design seems to be no-op.
  2. cargo dv clean seems redundant now, cargo clean will do all the things.

Comment thread src/main.rs Outdated
@Marsman1996

Copy link
Copy Markdown
Collaborator Author
  1. cargo dv clean seems redundant now, cargo clean will do all the things.

I almost forget this command, since the Makefile only uses cargo clean now

@rikosellic

Copy link
Copy Markdown
Collaborator

May be we can just remove cargo dv clean?

@Marsman1996

Copy link
Copy Markdown
Collaborator Author

May be we can just remove cargo dv clean?

But it's weird to have only build/verify without clean for a new user (if there is any🤣)

@rikosellic

Copy link
Copy Markdown
Collaborator

Indeed, not a big issue.

@rikosellic

Copy link
Copy Markdown
Collaborator

LGTM!

@rikosellic
rikosellic merged commit 4f29d1d into asterinas:main Jul 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants