chore: fix clippy, cargo update#127
Merged
jlizen merged 2 commits intoasync-profiler:mainfrom Mar 10, 2026
Merged
Conversation
Contributor
Author
|
cc @jlizen |
Contributor
Author
|
At least my MSRV fix to Smithy is working so no MSRV pokery is needed |
Contributor
Author
|
Ignoring the nightly clippy error |
Contributor
Author
|
AwsProfilerMetadataError is public and it's not worth playing with the API for this |
The AWS config error is large. This is not worth wrapping in a Box since it is an API breakage. For the private variant, do add a box
Contributor
Author
|
Fixed the clippy lint |
Contributor
Author
|
need another review @jlizen - it seems that the aws config struct has grown in size slightly over the cargo update which has triggered the clippy lint, so I ignored / boxed the struct to deal with it. |
jlizen
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📬 Issue #, if available:
DoS in quinn-proto: https://rustsec.org/advisories/RUSTSEC-2026-0037.html
✍️ Description of changes:
No release needed, just a Cargo.lock update.
Also, boxed an error enum variant to deal with a new clippy lint. Bypassed the lint in another place because it seemed wrong, plus that would be a breaking change.
🔏 By submitting this pull request