feat: support additional history filenames in replxx importer #3005
+17
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation of the
replxximporter, from PR #2024, only supported.histfileas a filename for the history file, since there is no default filename. However, the replxx codebase does usereplxx_history.txtas an example history filename (see here and here), so this patch adds support for that as an alternative filename.The implementation was modeled after the one currently used for the
zshhistory file importer, which also means thereplxximporter now produces a human-friendly error if no history file is found in the expected path(s).Checks
/cc @amosbird who introduced this importer in #2024.