Remove deprecated flavor sampling rate of 22500#579
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves support for the deprecated 22500 Hz flavor sampling rate and its warning, enforcing only the officially supported sampling rates and cleaning up the corresponding test. Flow diagram for updated sampling_rate validation in flavor initflowchart TD
A[sampling_rate passed to __init__] --> B{sampling_rate is not None}
B -- no --> Z[Return without sampling_rate]
B -- yes --> C[Cast sampling_rate to int]
C --> D{sampling_rate in define.SAMPLING_RATES}
D -- yes --> E[Continue initialization]
D -- no --> F[raise ValueError]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
frankenjoe
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #484
In #484 we promised to remove the deprecated flavor sampling rate of 22500 Hz in version 1.13.0. As we have now released version 1.13.0, it's time to remove it.