chore: return response headers in Authlete API response #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaikathaque
commented
May 14, 2025
pom.xml
Outdated
| <properties> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <authlete-java-common.version>4.20</authlete-java-common.version> | ||
| <authlete-java-common.version>4.21-SNAPSHOT</authlete-java-common.version> |
Member
Author
There was a problem hiding this comment.
Will have to change this before merging.
shaikathaque
commented
May 14, 2025
| </configuration> | ||
| </plugin> | ||
| </reportPlugins> | ||
| <!-- <reportPlugins>--> |
Member
Author
There was a problem hiding this comment.
Needed to temporarily comment this because it was preventing me from running mvn clean install -Dgpg.skip=true
CriGoT
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
ENG-3627
Context / Summary
Returns response headers included in the Authlete ApiResonse from
authlete-java-commonin the response.Description / Changes Made
ApiResponseobject.Breaking Changes
No, this approach was chosen with backwards compatibility in mind.
Testing Instructions
retrieve-response-headersofauthlete-java-common,authete-java-jaxrsandjava-oauth-servermvn clean install -Dgpg.skip=truein each directory to make sure the code changes are installed in your local maven repositoryauthlete.propertiesinjava-oauth-serverto use your Authlete 3 service.Send Request. This triggers the/authorizeendpoint to be called.java-oauth-server. You should see a the response headers logged, which include a hardcoded request id that was included in the request.Can use these branch to test:
authlete/java-oauth-server@master...retrieve-response-headers
authlete/authlete-java-common#116
Added Tests?
TODO
Related MRs
authlete/authlete-java-common#116