fix: statically link Linux amd64 binary with musl#23
Open
devrel-ditto wants to merge 1 commit intoava-labs:mainfrom
Open
fix: statically link Linux amd64 binary with musl#23devrel-ditto wants to merge 1 commit intoava-labs:mainfrom
devrel-ditto wants to merge 1 commit intoava-labs:mainfrom
Conversation
The release binary requires glibc 2.38+ because ubuntu-latest (24.04) dynamically links against its system glibc. This breaks on Amazon Linux 2023, Ubuntu 22.04, RHEL 9, and other common distros. Switch Linux amd64 builds to musl-gcc with static linking, producing a portable binary that runs on any Linux distro. Fixes ava-labs#22
devrel-ditto
requested review from
containerman17,
martineckardt and
owenwahlgren
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22 — Linux release binary requires glibc 2.38+, fails on Amazon Linux 2023 and other common distros.
Problem
ubuntu-lateston GitHub Actions is now Ubuntu 24.04 (glibc 2.39). The Linux amd64 binary dynamically links against it:Affected distros: Amazon Linux 2023, Ubuntu 22.04, Debian 12, RHEL/Rocky 9.
Fix
musl-gccwith-extldflags '-static'Testing
Built and verified on Amazon Linux 2023 (glibc 2.34):