security: validate genesis JSON and keystore file permissions#5
Open
owenwahlgren wants to merge 1 commit intomainfrom
Open
security: validate genesis JSON and keystore file permissions#5owenwahlgren wants to merge 1 commit intomainfrom
owenwahlgren wants to merge 1 commit intomainfrom
Conversation
- Add json.Valid() check before passing genesis data to P-Chain transaction builder, preventing wasted fees on malformed input - Add file permission validation when loading keystore files, refusing to read keys with insecure permissions (e.g. 0644) and providing actionable fix instructions - Skip permission check on Windows where POSIX perms don't apply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two security hardening fixes from production readiness audit:
cmd/chain.go): Validates JSON structure withjson.Valid()before submitting to P-Chain, preventing wasted transaction fees on malformed inputpkg/keystore/keystore.go): Validates file permissions (0600) when loading key files, refusing to read keys with insecure permissions and providing actionable fix instructions (no-op on Windows)Test plan
go vet ./...passesgo test ./pkg/... ./cmd/...all passchmod 644a key file, expect refusal with fix instruction