Skip to content

chore(fletch): bump to fletch 2.3.0#9

Merged
francescovallone merged 2 commits intoavesbox:mainfrom
kartikey321:feat/fletch-2.3.0
Apr 15, 2026
Merged

chore(fletch): bump to fletch 2.3.0#9
francescovallone merged 2 commits intoavesbox:mainfrom
kartikey321:feat/fletch-2.3.0

Conversation

@kartikey321
Copy link
Copy Markdown
Contributor

@kartikey321 kartikey321 commented Apr 13, 2026

Summary

  • Bump fletch dependency from 2.2.0 → 2.3.0 (published on pub.dev)
  • Update config version to 2.3.0
  • Remove unused dart:convert import in fletch_bench.dart

What's new in 2.3.0

  • RadixRouter refactor — static routes now use an O(1) HashMap pre-check, eliminating radix tree traversal for fully-static paths
  • Response.send de-async — removes one Future state machine allocation per request, reducing GC pressure
  • Optional params (:id?) and named glob (*:name) routing features
  • 318 tests, 97.0% line coverage

Summary by CodeRabbit

  • Chores
    • Upgraded framework and package references to the 2.3.0 release.
  • Behavior Change
    • Cookie parsing is now enabled by default in the benchmark server, so incoming cookies are automatically processed.
  • Documentation
    • Clarified API endpoint comments to explain request/response behavior for the echo route.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f6984906-769a-4671-a319-39e9c524940e

📥 Commits

Reviewing files that changed from the base of the PR and between 1362757 and 19489f9.

📒 Files selected for processing (1)
  • frameworks/fletch/bin/fletch_bench.dart
🚧 Files skipped from review as they are similar to previous changes (1)
  • frameworks/fletch/bin/fletch_bench.dart

📝 Walkthrough

Walkthrough

This PR bumps Fletch from 2.2.0 to 2.3.0 in config and dependency files, removes an explicit useCookieParser: false constructor option in the benchmark server, and adds a clarifying comment to the /api/echo route. (47 words)

Changes

Cohort / File(s) Summary
Configuration & Dependency Updates
configs/http/fletch.yaml, frameworks/fletch/pubspec.yaml
Version updated from 2.2.02.3.0 in config and package manifest.
Benchmark Server
frameworks/fletch/bin/fletch_bench.dart
Removed explicit useCookieParser: false from Fletch constructor; added an inline comment clarifying /api/echo echoes request body as JSON.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • chore: update fletch benchmarks to v2.2.0 #7: Previously added useCookieParser and requestTimeout constructor args and bumped Fletch to v2.2.0; directly touches the same benchmark constructor usage now reverted/updated here.

Poem

🐰 Version two-point-three hops into place,
With cookies no longer cluttering the race,
The echo route chirps its purpose so clear,
Benchmarks hum softly as changes appear,
A tiny hop forward—hooray! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(fletch): bump to fletch 2.3.0' directly and accurately summarizes the main change—updating the fletch dependency from 2.2.0 to 2.3.0 across all three affected files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@frameworks/fletch/bin/fletch_bench.dart`:
- Line 15: Update the inaccurate comment to reflect that the handler reads
req.body and returns it via res.json rather than echoing a raw body without JSON
parsing/re-encoding; specifically reference the actual flow using req.body and
res.json in the comment so it accurately describes that the request body is read
and returned as a JSON response.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4ec03c5e-6af0-4f46-bb88-59f8ef53201e

📥 Commits

Reviewing files that changed from the base of the PR and between fa37bc7 and 1362757.

⛔ Files ignored due to path filters (1)
  • frameworks/fletch/pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • configs/http/fletch.yaml
  • frameworks/fletch/bin/fletch_bench.dart
  • frameworks/fletch/pubspec.yaml

Comment thread frameworks/fletch/bin/fletch_bench.dart Outdated
@kartikey321
Copy link
Copy Markdown
Contributor Author

@francescovallone can we merge this?

@francescovallone francescovallone merged commit 0f3abfb into avesbox:main Apr 15, 2026
1 check passed
@francescovallone
Copy link
Copy Markdown
Contributor

Merged, I will start the benchmarks run on the server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants