chore(fletch): bump to fletch 2.3.0#9
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR bumps Fletch from 2.2.0 to 2.3.0 in config and dependency files, removes an explicit Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frameworks/fletch/bin/fletch_bench.dart`:
- Line 15: Update the inaccurate comment to reflect that the handler reads
req.body and returns it via res.json rather than echoing a raw body without JSON
parsing/re-encoding; specifically reference the actual flow using req.body and
res.json in the comment so it accurately describes that the request body is read
and returned as a JSON response.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4ec03c5e-6af0-4f46-bb88-59f8ef53201e
⛔ Files ignored due to path filters (1)
frameworks/fletch/pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
configs/http/fletch.yamlframeworks/fletch/bin/fletch_bench.dartframeworks/fletch/pubspec.yaml
|
@francescovallone can we merge this? |
|
Merged, I will start the benchmarks run on the server |
Summary
dart:convertimport infletch_bench.dartWhat's new in 2.3.0
Response.sendde-async — removes one Future state machine allocation per request, reducing GC pressure:id?) and named glob (*:name) routing featuresSummary by CodeRabbit