Skip to content

fix: remove writeMemoryFile from session handling - #801

Merged
avoidwork merged 1 commit into
mainfrom
fix/session-write-format
Aug 17, 2026
Merged

fix: remove writeMemoryFile from session handling#801
avoidwork merged 1 commit into
mainfrom
fix/session-write-format

Conversation

@avoidwork

Copy link
Copy Markdown
Owner

Description

Removed writeMemoryFile from handleConversation() in index.js. This function was writing session files in a different format (timestamp-named files with title/timestamp frontmatter) than saveSession() (UUID-named files with threadId/startedAt frontmatter). The dual-write caused the reflectionSessions tool to find no valid sessions, since it looks for startedAt in frontmatter.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)

Testing

  • Verified writeMemoryFile is no longer called in handleConversation()
  • Confirmed saveSession() remains the sole session writer (called on shutdown)
  • reflectionSessions tool expects startedAt in frontmatter — only the old format provides this

Coverage

  • Line coverage maintained

Checklist

  • npm run lint passes
  • Tests pass with maintained line coverage
  • No forbidden patterns used
  • Conventional Commit style applied

writeMemoryFile was writing session files in a different format
than saveSession, causing the reflection tool to find no valid
sessions. Only saveSession should write session files.
@avoidwork avoidwork added the bug Something isn't working label Aug 17, 2026
@avoidwork avoidwork self-assigned this Aug 17, 2026
@avoidwork
avoidwork merged commit f82ee9e into main Aug 17, 2026
3 checks passed
@avoidwork
avoidwork deleted the fix/session-write-format branch August 17, 2026 11:12
@avoidwork avoidwork mentioned this pull request Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant