Conversation
| */ | ||
|
|
||
| // {fact rule=insecure-hashing@v1.0 defects=0} | ||
| // Compliant: secured hasing algorithm `Sha256` used |
There was a problem hiding this comment.
Correct the Hashing spell "Secure hashing algorithm SHA256 used"
| */ | ||
|
|
||
| // {fact rule=os-command-injection@v1.0 defects=0} | ||
| // Compliant: string arguments instead of user input |
There was a problem hiding this comment.
String arguments instead of user input
| */ | ||
|
|
||
| // {fact rule=untrusted-data-in-decision@v1.0 defects=1} | ||
| // Noncompliant: Insecure hashing algorithm `Md2` used |
There was a problem hiding this comment.
Insecure due to the potential for arbitrary user input, non-existent file paths, and unreliable data
| */ | ||
|
|
||
| // {fact rule=insecure-connection@v1.0 defects=0} | ||
| // Compliant: Used suppaftp for connection |
There was a problem hiding this comment.
Use of suppaftp for connection
| */ | ||
|
|
||
| // {fact rule=untrusted-data-in-decision@v1.0 defects=0} | ||
| // Compliant: secured hasing algorithm `Sha256` used |
There was a problem hiding this comment.
Use of external crates and creating CLI applications with clap
|
|
||
| fn vulnerable_remove_dir_all(dir_path: &str) { | ||
| if fs::metadata(dir_path).unwrap().is_dir() { | ||
| // ruleid: rust-race-condition-remove-dir-all |
There was a problem hiding this comment.
remove this line "// ruleid: rust-race-condition-remove-dir-all"
| */ | ||
|
|
||
| // {fact rule=incorrect-conversion-of-numeric-types@v1.0 defects=0} | ||
| // Compliant: verify that the resulting rounded value |
There was a problem hiding this comment.
recheck this sentence, unclear what you wanted to conevey
| */ | ||
|
|
||
| // {fact rule=incorrect-conversion-of-numeric-types@v1.0 defects=1} | ||
| // Noncompliant: not verify that the resulting rounded value |
There was a problem hiding this comment.
recheck this sentence, unclear what you wanted to conevey
2 participants
added rust detecter library test cases for completed rules