fix(android): call cleanup on view drop to prevent resource leaks#201
Open
Yoon-Hae-Min wants to merge 1 commit intoaws:mainfrom
Open
fix(android): call cleanup on view drop to prevent resource leaks#201Yoon-Hae-Min wants to merge 1 commit intoaws:mainfrom
Yoon-Hae-Min wants to merge 1 commit intoaws:mainfrom
Conversation
`AmazonIvsView.cleanup()` was only called from `onHostDestroy`, meaning that when the React view was removed (e.g. navigating away) without the host being destroyed, player resources (listeners, observers, background service, preloaded sources) were never released. Override `onDropViewInstance` in `AmazonIvsViewManager` to ensure `cleanup()` is called when the native view is dropped by React.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
AmazonIvsView.cleanup()is only called fromonHostDestroy, which is tied to the Android Activity lifecycle. When a React component is unmounted (e.g. navigating away via React Navigation), the Activity remains alive — soonHostDestroyis never called, and player resources (IVS player instance, listeners, background service, preloaded sources, timers, broadcast receivers) are never released.In our production app, we observed that player resources were not being released when the component was unmounted, causing resource leaks.
This adds an
onDropViewInstanceoverride inAmazonIvsViewManagerto callcleanup()when React drops the native view.