Skip to content

otel/8: add ExecutionOtelPlugin conformance cases - #28

Merged
zhongkechen merged 28 commits into
mainfrom
codex/execution-otel-plugin-tests
Jul 28, 2026
Merged

otel/8: add ExecutionOtelPlugin conformance cases#28
zhongkechen merged 28 commits into
mainfrom
codex/execution-otel-plugin-tests

Conversation

@zhongkechen

Copy link
Copy Markdown
Contributor

Summary

Stack

Validation

  • hatch run test:all (172 passed)
  • hatch run types:check
  • hatch run yaml:lint
  • hatch fmt --check packages scripts
  • hatch run dist:all
  • TypeScript typecheck and Rollup build against JavaScript SDK main at 84d05d4
  • Python plugin import and constructor smoke check against PR 576 head

@zhongkechen
zhongkechen force-pushed the codex/execution-otel-plugin-tests branch from 01930a1 to e94382d Compare July 24, 2026 20:17
@zhongkechen
zhongkechen force-pushed the codex/execution-otel-plugin-tests branch from e94382d to 9fce7a0 Compare July 24, 2026 21:59
Base automatically changed from codex/typescript-s3-collector to main July 24, 2026 22:40
@zhongkechen
zhongkechen force-pushed the codex/execution-otel-plugin-tests branch from 9fce7a0 to bada378 Compare July 24, 2026 22:42
@zhongkechen
zhongkechen marked this pull request as ready for review July 24, 2026 22:51
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime July 24, 2026 22:51 — with GitHub Actions Inactive
@zhongkechen
zhongkechen had a problem deploying to ai-pr-review-runtime July 24, 2026 22:51 — with GitHub Actions Failure
@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime July 24, 2026 23:23 — with GitHub Actions Inactive
@zhongkechen
zhongkechen had a problem deploying to ai-pr-review-runtime July 24, 2026 23:23 — with GitHub Actions Failure
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen had a problem deploying to ai-pr-review-runtime July 25, 2026 00:01 — with GitHub Actions Failure
@zhongkechen
zhongkechen had a problem deploying to ai-pr-review-runtime July 25, 2026 00:01 — with GitHub Actions Failure
@zhongkechen
zhongkechen force-pushed the codex/execution-otel-plugin-tests branch from de4c2f8 to df744da Compare July 25, 2026 00:04
Comment thread .github/workflows/opentelemetry-execution.yml Outdated
Comment thread .github/workflows/opentelemetry-invocation.yml Outdated
@zhongkechen
zhongkechen force-pushed the codex/execution-otel-plugin-tests branch from 6987b68 to 0805e2e Compare July 28, 2026 19:02
@zhongkechen
zhongkechen had a problem deploying to ai-pr-review-runtime July 28, 2026 19:02 — with GitHub Actions Failure
@zhongkechen
zhongkechen had a problem deploying to ai-pr-review-runtime July 28, 2026 19:02 — with GitHub Actions Failure
OpenTelemetry plugin is evolving quickly. Pin the two Git requirements to the
same commit when a reproducible build is needed.
both packages at the merge commit of
[Python SDK PR 576](https://github.com/aws/aws-durable-execution-sdk-python/pull/576),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to update this after launch?

@zhongkechen
zhongkechen merged commit 09e63bc into main Jul 28, 2026
11 of 21 checks passed
@zhongkechen
zhongkechen deleted the codex/execution-otel-plugin-tests branch July 28, 2026 19:25
@zhongkechen
zhongkechen had a problem deploying to ai-pr-review-runtime July 28, 2026 19:35 — with GitHub Actions Failure
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime July 28, 2026 19:35 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown

Codex AI review

  • [P1] Count execution-view invocation spans correctlypackages/aws-durable-execution-conformance-tests-otel/test-requirements/otel-execution/otel-execution-2.yaml:27
    minimum_invocations uses _invocation_count(), which only recognizes lowercase invocation, while the new execution-view assertions use Invocation. Cases 2, 3, 9, 10, 11, 17, and 18 will report zero canonical invocations. Normalize the name or recognize both forms, and add an execution-view count test.

  • [P2] Prevent hosted Python stacks from colliding across suites.github/workflows/python-opentelemetry.yml:33
    Including the suite in the concurrency group allows invocation and execution dispatches to run together, but Datadog and Dash0 still use shared stack names. Concurrent runs can race while deploying different OtelSuite values. Add the suite suffix to those test names or serialize Python OTel workflows across suites.

Reviewed commit 677dab35dca177d4a0456e9c7777d83cdad7e074. Workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants