Skip to content

feat: rewrite controlplane integration tests with pytest#323

Merged
Hweinstock merged 1 commit intoaws:mainfrom
Hweinstock:integ-test/rewrite-controlplane
Mar 12, 2026
Merged

feat: rewrite controlplane integration tests with pytest#323
Hweinstock merged 1 commit intoaws:mainfrom
Hweinstock:integ-test/rewrite-controlplane

Conversation

@Hweinstock
Copy link
Contributor

Issue #, if available: #316

Description of changes:

Problem

test_controlplane.py mixed unit and integration tests. Had a bug filtering memories by UUID prefix (never matched). Used pytest.mark.depends and pytest.mark.parallel adding complexity.

Solution

  • Rewrite as integration-only TestMemoryControlPlaneClient class with 6 ordered tests.
  • Fixed list filter to use name prefix.
  • Added conftest.py with poll_until helper.
  • Added pytest-order to dev deps.
  • Add to CI to run in parallel to avoid sequential slow down.

Testing

passed in dev account, ~6 min runtime.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@2afa155). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage        ?   90.83%           
=======================================
  Files           ?       42           
  Lines           ?     4036           
  Branches        ?      620           
=======================================
  Hits            ?     3666           
  Misses          ?      203           
  Partials        ?      167           
Flag Coverage Δ
unittests 90.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Hweinstock Hweinstock force-pushed the integ-test/rewrite-controlplane branch from 880e75f to 1e45a62 Compare March 11, 2026 21:17
@Hweinstock Hweinstock force-pushed the integ-test/rewrite-controlplane branch from 1e45a62 to 65af895 Compare March 11, 2026 21:26
@Hweinstock Hweinstock marked this pull request as ready for review March 11, 2026 21:38
@Hweinstock Hweinstock requested a review from a team March 11, 2026 21:39
@Hweinstock Hweinstock merged commit 7d7fa48 into aws:main Mar 12, 2026
17 of 18 checks passed
@Hweinstock Hweinstock deleted the integ-test/rewrite-controlplane branch March 12, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants