feat(memory): add boto3_session parameter to MemoryClient#330
Merged
Conversation
Allow MemoryClient to accept an optional boto3.Session, consistent with MemorySessionManager. This enables named profiles, custom credentials, and other session-level configuration.
jariy17
force-pushed
the
feat/boto3-session-memory-client
branch
from
606034d to
6896275
Compare
Hweinstock
approved these changes
Mar 12, 2026
| self.gmcp_client = session.client( | ||
| "bedrock-agentcore-control", region_name=self.region_name, config=client_config | ||
| ) | ||
| self.gmdp_client = session.client("bedrock-agentcore", region_name=self.region_name, config=client_config) |
Contributor
There was a problem hiding this comment.
does it make sense to inject client configuration as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#44
Description of changes:
Add optional
boto3_sessionparameter toMemoryClient.__init__(), enabling named profiles, custom credentials, and other session-level configuration. This makesMemoryClientconsistent withMemorySessionManager, which already acceptsboto3_session.Based on #90 by @manikawnth — rebased and updated to work with the current codebase.
Changes
boto3_sessionparameter toMemoryClient.__init__()session.client()instead ofboto3.client()for creating boto3 clientsboto3.Sessioninstead ofboto3.clientboto3_sessionparameter (with and without explicitregion_name)Test plan
boto3_sessionusageBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.