Rename FMKB to BMKB in the managed KB sample - #1865
Open
shraiyya wants to merge 3 commits into
Open
Conversation
added 3 commits
July 30, 2026 11:51
Replace every occurrence of the FMKB abbreviation with BMKB across this sample. This aligns it with the BMKB naming already used elsewhere for Bedrock Managed Knowledge Bases, including the bedrock-samples notebook this sample's README links to (01-create-bmkb-s3.ipynb). The change is naming only. Renamed tokens are all internal to the sample: the generated env file (.env.fmkb-gateway), the --name-prefix default and the resource names derived from it (fmkb-sample*), the runtime agent name (fmkb_gateway_agent), the Strands entrypoint filename, and prose/comment mentions of FMKB. No package name, AWS API identifier, or external URL was touched, and no control flow, argument, or logic was altered.
Resolve the ruff findings reported by the python-lint workflow so the
sample passes both `ruff check` and `ruff format --check`:
- drop three `# noqa: E402` directives that the repo's ruff config
already ignores globally, so they were flagged as unused (RUF100)
- use `str.removeprefix("export ")` instead of a conditional slice
when parsing the generated env file (FURB188)
- merge the nested `async with` into a single parenthesized statement
(SIM117) and reformat the block per `ruff format`
- sort the import block in setup_gateway.py (I001)
- annotate `kb_id` as `str | None` instead of `Optional[str]` (UP045);
the module already has `from __future__ import annotations`
All changes are behaviour-preserving. The sample's README already
requires Python 3.10+, which covers both the parenthesized `async with`
and the `X | None` annotation syntax.
|
Latest scan for commit: Security Scan ResultsScan Metadata
SummaryScanner ResultsThe table below shows findings by scanner, with status based on severity thresholds and dependencies: Column Explanations: Severity Levels (S/C/H/M/L/I):
Other Columns:
Scanner Results:
Severity Thresholds (Thresh Column):
Threshold Source: Values in parentheses indicate where the threshold is configured:
Statistics calculation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the
FMKBabbreviation toBMKBthroughout the managed Knowledge Base sample under01-features/03-connect-your-agent-to-anything, including the sample directory itself. Naming only — no logic, control flow, or argumentchanges.
Why
BMKBis the abbreviation used elsewhere for Bedrock Managed Knowledge Bases, including theaws-samples/amazon-bedrock-samplesnotebook this sample's own README links to as a prerequisite (01-create-bmkb-s3.ipynb). This sample was the outlier.What changed
Every renamed token is internal to the sample:
.env.fmkb-gateway->.env.bmkb-gateway--name-prefixdefault and the gateway/role/target names derived from it,fmkb-sample*->bmkb-sample*fmkb_gateway_agent->bmkb_gateway_agentfmkb_gateway_strands.py->bmkb_gateway_strands.py(contents byte-identical)FMKB->BMKB04-fmkb-managed-kb->04-bmkb-managed-kbNo package name, AWS API identifier, or external URL was touched. A repo-wide search found no reference to the old directory path outside the sample itself, so the directory rename breaks no links.
Verification
Each file from
mainwas taken,fmkb->bmkbandFMKB->BMKBapplied, and the result compared byte-for-byte against the committed version — exact match on all 17 files, confirming no incidental edits. Python sources compile and the IAM JSON documents still parse. Sibling samples (01-code-interpreter,02-browser,03-web-search) and the parent README are untouched.Note for reviewers
images/architecture.pngstill renders "FMKB" in its title and KB node. It is a binary asset that must be re-exported from draw.io, which was deliberately kept out of this text-only rename. Happy to add the re-exported PNG here if you would prefer it land together.