Disable windows asan#532
Merged
Merged
Conversation
MSVC requires all code to be compiled with ASAN because it embeds neccessary info into object files. This includes linked 3rd-party libraries. So there are 3 options: 1. Disable ASAN 2. Use header-only 3rd-party libs 3. Rebuild 3rd-party libs with ASAN instrumentation (impossible for closed-source 3rd-party dependencies). While the 3rd option is preferrable, I choose to disable ASAN on windows as an easy fix to make CI working for now. I am going to investigate how to rebuild 3rd-party libs vendored with Conan later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.