Fix integer overflow in LDA partition bookkeeping for large corpora#227
Open
sldyns wants to merge 1 commit into
Open
Fix integer overflow in LDA partition bookkeeping for large corpora#227sldyns wants to merge 1 commit into
sldyns wants to merge 1 commit into
Conversation
Author
|
I took a closer look at the failures. Aside from macOS Intel + Python 3.9, the remaining failures all appear to be the same flaky reproducibility test ( The macOS Intel + Python 3.9 failure is different ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes integer overflow in the LDA multi-worker partition path for very large corpora.
Root cause
LDAModel::updatePartition()accumulated total token counts with a literal0, which makesstd::accumulatesum in 32-bit integer space before assigning back to a wider type.For corpora whose total token count exceeds
INT32_MAX, this can overflow and corrupt partition bookkeeping in thePARTITIONpath.Changes
uint64_tfor the partition total-count accumulatoruint64_tfor the partition cumulative-count accumulatoruint64_tfortotCfin the term-weighting pathNotes
This change is intended to preserve behavior for normal corpora while avoiding overflow for large-token inputs.