Conversation
bquan0
requested changes
Feb 27, 2025
Contributor
bquan0
left a comment
bquan0
left a comment
There was a problem hiding this comment.
Overall, looks pretty good! Just a few small things to fix.
Contributor
|
The latest commit 867ef3e is NOT working. It's because of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to initialise data so that it can be sent through CAN. I decided to create a function the assigns random values and we will verify if those values are reliably sent over. Other techniques can be defined with different values of DEBUG_TECHNIQUE