Override js-yaml to ^4.3.0 to fix npm audit failure#132
Merged
Conversation
@redocly/openapi-core pins js-yaml 4.2.0, which is vulnerable to GHSA-52cp-r559-cp3m (high). Force ^4.3.0 via npm overrides until Redocly picks up the fix.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates dependency overrides in the TypeScript workspace to address package version constraints.
Changes:
- Adds an override for
js-yaml. - Adjusts the
overridesJSON formatting (adds a trailing comma afterminimatch).
Files not reviewed (1)
- typescript/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm Audit CI check is failing on every open PR because
@redocly/openapi-core(a transitive dependency ofopenapi-typescript) pinsjs-yamlat 4.2.0, which is vulnerable to GHSA-52cp-r559-cp3m (high severity, quadratic CPU consumption via YAML merge-key chains).Redocly's latest 1.x release still pins the vulnerable version, so this forces
js-yamlto^4.3.0via npmoverrides— the same approach already used forminimatch. The override can be dropped once Redocly picks up the fix.Typecheck and the test suite (92 tests) pass with the override in place.
Summary by cubic
Force
js-yamlto^4.3.0via npmoverridesto fix CI npm audit failures caused by@redocly/openapi-corepinningjs-yaml@4.2.0. Addresses GHSA-52cp-r559-cp3m (high severity); typecheck and tests pass.overrides.js-yaml: ^4.3.0intypescript/package.json.js-yaml@4.3.0.@redocly/openapi-coreupgrades.Written for commit c9a881a. Summary will update on new commits.