File descriptor leak in saveStateSnapshot#188
Closed
AnyCPU wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
The branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is called on every state-mutating RPC operation (deploy, remove, pause, resume, rollout). Under active redeployment, this can exhaust the process file descriptor limit and cause subsequent file/socket operations to fail with EMFILE (too many open files).
Root cause
The matching read function RestoreLastSavedState had the same bug, which was fixed in commit 1a660f7 (Sep 2024) — but the write path was missed. The bug has been present since state persistence was introduced in commit 9451420 (Mar 2024).
Fix
Add defer f.Close() after the os.Create error check. Additionally, add slog.Error logging on all error paths, since every call site uses defer r.saveStateSnapshot() and discards the return value.