Return consistent redirect on duplicate registration - #213
Open
SakusenSec wants to merge 1 commit into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts the users signup flow by changing the redirect behavior when a RecordNotUnique error occurs (likely when a user attempts to sign up with an email that already exists).
Changes:
- Remove passing
email_addressas a query param when redirecting to the login page afterActiveRecord::RecordNotUnique.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| redirect_to root_url | ||
| rescue ActiveRecord::RecordNotUnique | ||
| redirect_to new_session_url(email_address: user_params[:email_address]) | ||
| redirect_to new_session_url |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user attempts to register with an email address that is already taken, the RecordNotUnique rescue redirects to /session/new?email_address=. A successful registration redirects to /. The differing redirect targets reveal whether an address is registered.
This PR removes the email_address parameter from the duplicate-registration redirect, making both paths return an opaque redirect without leaking registration state. The existing-user flow still lands on the sign-in page; it just no longer pre-fills the email field.