Fix labelsToWatch to keep workspace files after local-repo labels#823
Open
neyo8826 wants to merge 1 commit into
Open
Fix labelsToWatch to keep workspace files after local-repo labels#823neyo8826 wants to merge 1 commit into
neyo8826 wants to merge 1 commit into
Conversation
Member
|
Hrm... this might well be a necessary change, but I'm not 100% sure. Can you help me understand what isn't working and why you think this will resolve the issue? |
Author
|
bazel query deps(...) outputs the list in local->remote order (// -> @...//) but cquery interleaves them, so the loop cannot stop there. it misses a lot of deps that way |
Member
|
Okay, that seems reasonable. Can you add an e2e test that demonstrates the failure that is resolved by this change? |
… add a regression test for mixed label ordering
Author
|
added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes my js_run_devserver from aspect_rules_js