Allow passing keystore password other than android#426
Allow passing keystore password other than android#426snazhmudinov wants to merge 1 commit intobazelbuild:mainfrom
Conversation
| ), | ||
| keystore_signing_password = attr.string( | ||
| doc = """ | ||
| The password for the KeyStore that contains the signer's key and certificate. |
There was a problem hiding this comment.
taken from official Android documentation: https://developer.android.com/tools/apksigner?hl=en#options-sign-key-cert
|
cc: @meisterT |
|
I'm not sure that this is good idea because it could appear to encourage checking passwords into source control since this goes into a build file. In general with bazel (and internally with blaze) signing outputs is handled outside of the build system (besides the debug key in the case of android). |
Yes, I was having in mind the password for the debug keystore. If that's okay, where would the logic go? |
snazhmudinov
force-pushed
the
sherozn/make-keystore-password-configurable
branch
from
1b7f9c1 to
91fecd5
Compare
|
@ahumesky any thoughts on the last comment? |
2 participants
Addresses bazelbuild/bazel#10862