Speed up tar packing by lower compresslevel and create symbolic links for same files#887
Speed up tar packing by lower compresslevel and create symbolic links for same files#887gdh1995 wants to merge 1 commit intobazelbuild:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
b9ed911 to
4a90992
Compare
…links for same files
4a90992 to
ee4999c
Compare
|
These changes seem reasonable to me. However, I wonder if we should break it out into two or three PRs:
What do you think? |
|
Ah in fact my original work in my private workspace just has exact 3 commits to add such 3 features. I'll split it tomorrow. |
aiuto
left a comment
There was a problem hiding this comment.
Can you make this two distinct PRs.
The compression level should be easy but the other thing looks like it has more general comments.
What's the problem
The current tar packaging process is not efficient enough, as evidenced by:
add_filewill create N identical copies, significantly increasing the package size and time.How to solve
compresslevel: strwhich can be"" (auto, 6) | "0" | "1" | ... | "9"MappingManifestInfobesidesDefaultInfoto exposemanifest_fileandpackage_dirinfo to downstream targetsmerge_mappings: boolto enable this behavior manuallyauto_deduplicate: boolto identify added files across all manifest files by content paths and realpaths, and then auto-create symbolic links