Add target-latency and current-latency to Chronicle (Update of #361)#378
Merged
ShiningTrapez merged 9 commits intomasterfrom Apr 8, 2025
Merged
Add target-latency and current-latency to Chronicle (Update of #361)#378ShiningTrapez merged 9 commits intomasterfrom
target-latency and current-latency to Chronicle (Update of #361)#378ShiningTrapez merged 9 commits intomasterfrom
Conversation
… low-latency-debug
ryanmccartney
previously approved these changes
Apr 7, 2025
Contributor
|
Updated to only show target and current latency values when playing back a live stream |
eirikbjornr
previously approved these changes
Apr 7, 2025
Contributor
eirikbjornr
left a comment
eirikbjornr
left a comment
There was a problem hiding this comment.
LGTM! Left one comment on dynamic vs static metric
eirikbjornr
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📺 What
Adds MSE target latency and current latency reporting to the debug menu. Useful when debugging low-latency content, particularly on TV hardware where some decoder behaviours do not match what might be expected
🛠 How
Uses existing
DebugTool.dynamicMetric()method to add these metrics each time atimeupdateevent is called.✅ Testing
Added underlying dash.js functions to the
mockDashInstance. No additional unit tests were added.Test Guidelines
👀 See
New fields are seen below when the MSE strategy is chosen. The values
NaNand 0 are seen when VOD content is played.The same changes are shown again, but using live low-latency content. Extra fields, along with the existing playback rate field, can be used to determine whether low-latency content is performing as expected.
#361