Harden gcloud credential injection and add upstream error diagnostics - #27
Merged
Conversation
Prevent the GCloudInjector's token refresh from accidentally routing through the proxy's own token vendor (which returns dummy tokens) by setting Proxy: nil on the HTTP transport. Add a guard that rejects synthetic/short tokens before injection, and diagnostic logging (GCLOUD_TOKEN_DEBUG, UPSTREAM_ERROR) to distinguish proxy-generated errors from upstream errors when debugging 401s. - Set Proxy: nil on GCloudInjector and ChatGPTInjector HTTP transports - Reject tokens matching SyntheticToken or shorter than 20 chars - Extract SyntheticToken constant shared between token vendor and guard - Add OnResponse handler logging upstream 4xx/5xx for injected requests - Add integration test: upstream 429/500/503 pass through unchanged - Add unit tests: GCloudInjector never returns InjectAuthRequired - Add != 401 assertion to credential injection failure test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent the GCloudInjector's token refresh from accidentally routing through the proxy's own token vendor (which returns dummy tokens) by setting Proxy: nil on the HTTP transport. Add a guard that rejects synthetic/short tokens before injection, and diagnostic logging (GCLOUD_TOKEN_DEBUG, UPSTREAM_ERROR) to distinguish proxy-generated errors from upstream errors when debugging 401s.