Replace golangci-lint remote hook with local system hook - #28
Merged
Conversation
The remote golangci-lint pre-commit hook was disabled due to a broken upstream dependency (MirrexOne/unqueryvet 403 on Go module proxy). Replace it with a local system hook that calls the pre-built binary directly, avoiding the upstream issue entirely. Since golangci-lint subsumes both govet and gofmt (both enabled in .golangci.yml), remove the now-redundant gofmt and go-vet pre-commit hooks and the fmt-check Makefile target. Update make lint to use golangci-lint, and add golangci-lint binary installation to make install-hooks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote golangci-lint pre-commit hook was disabled due to a broken upstream dependency (MirrexOne/unqueryvet 403 on Go module proxy). Replace it with a local system hook that calls the pre-built binary directly, avoiding the upstream issue entirely.
Since golangci-lint subsumes both govet and gofmt (both enabled in .golangci.yml), remove the now-redundant gofmt and go-vet pre-commit hooks and the fmt-check Makefile target. Update make lint to use golangci-lint, and add golangci-lint binary installation to make install-hooks.