Skip to content

Conversation

@harrison314
Copy link
Contributor

@harrison314 harrison314 commented Nov 29, 2025

Describe your changes

I made modifications that allow you to create a HashMLDsaSigner that can be used to sign an existing hash.

For proper functionality, it is necessary to accept the merge request #654

I added the same option for HashSlhDsaSigner.

My questions

  1. Is it necessary to add a check in the static HashMLDsaSigner CreateRawSigner(MLDsaParameters parametersWithoutPrehash, bool deterministic, DerObjectIdentifier preHashOid) method or is there a digest OID for preHashOid?
  2. Is it necessary to add a hash length check? I looked at RsaDigestSigner, but I didn't find this check in it.

How has this been tested?

Tested with my own application and with changes in #654

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have kept the patch limited to only change the parts related to the patch
  • This change requires a documentation update

See also Contributing Guidelines.

@peterdettman
Copy link
Collaborator

Thanks, @harrison314 . It looks reasonable, though I want to check with bc-java that the approaches are similar.

Some initial changes I'd prefer:

  • Use Prehash class instead of NullDigest
  • Use name "CreatePrehashSigner" instead of "CreateRawSigner"

@harrison314 harrison314 force-pushed the enabling-creation-of-raw-mldsa-signer branch from 966e61d to 77c4e4f Compare December 1, 2025 08:47
@harrison314 harrison314 force-pushed the enabling-creation-of-raw-mldsa-signer branch from 77c4e4f to da142b2 Compare December 1, 2025 08:48
@harrison314
Copy link
Contributor Author

Thanks for the quick response, I've made the required changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants