chore(php-lol): update nginx to 1.30.1#324
Open
Copilot wants to merge 2 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/bdossantos/dockerfiles/sessions/56557aec-f12f-4879-9528-5e319c0e33b4 Co-authored-by: bdossantos <245284+bdossantos@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
bdossantos
May 15, 2026 19:09
View session
There was a problem hiding this comment.
Pull request overview
This PR updates the nginx version used by all php-lol Dockerfile variants, keeping the PHP images aligned on the same nginx release.
Changes:
- Bumps
NGINX_VERSIONfrom1.28.2to1.30.1in PHP 8.1, 8.2, 8.3, and 8.4 variants.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
dockerfiles/php-lol/Dockerfile.8.1 |
Updates nginx source version for PHP 8.1 image. |
dockerfiles/php-lol/Dockerfile.8.2 |
Updates nginx source version for PHP 8.2 image. |
dockerfiles/php-lol/Dockerfile.8.3 |
Updates nginx source version for PHP 8.3 image. |
dockerfiles/php-lol/Dockerfile.8.4 |
Updates nginx source version for PHP 8.4 image. |
| APP_DIR=/usr/src/app \ | ||
| LIBMAXMINDDB_VERSION=1.7.1 \ | ||
| NGINX_VERSION=1.28.2 \ | ||
| NGINX_VERSION=1.30.1 \ |
| APP_DIR=/usr/src/app \ | ||
| LIBMAXMINDDB_VERSION=1.7.1 \ | ||
| NGINX_VERSION=1.28.2 \ | ||
| NGINX_VERSION=1.30.1 \ |
| APP_DIR=/usr/src/app \ | ||
| LIBMAXMINDDB_VERSION=1.7.1 \ | ||
| NGINX_VERSION=1.28.2 \ | ||
| NGINX_VERSION=1.30.1 \ |
Contributor
Author
There was a problem hiding this comment.
Implemented in 24e2ce3: updated tests/php-lol.yaml to add a container-structure test that asserts /usr/sbin/nginx -v reports nginx/1.30.1, so CI now validates the nginx version after this bump.
| APP_DIR=/usr/src/app \ | ||
| LIBMAXMINDDB_VERSION=1.7.1 \ | ||
| NGINX_VERSION=1.28.2 \ | ||
| NGINX_VERSION=1.30.1 \ |
Agent-Logs-Url: https://github.com/bdossantos/dockerfiles/sessions/8285474a-8bcf-4820-b545-364397ca68c7 Co-authored-by: bdossantos <245284+bdossantos@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps nginx from
1.28.2to1.30.1(latest stable) across all php-lol variants.Changes
NGINX_VERSION=1.30.1inDockerfile.8.1,Dockerfile.8.2,Dockerfile.8.3, andDockerfile.8.4